Add test to run tox warning-free in a subprocess.#564
Draft
samcunliffe wants to merge 4 commits intomainfrom
Draft
Add test to run tox warning-free in a subprocess.#564samcunliffe wants to merge 4 commits intomainfrom
tox warning-free in a subprocess.#564samcunliffe wants to merge 4 commits intomainfrom
Conversation
Reproduces #560.
samcunliffe
changed the title
tox in a subprocess.tox warning-free in a subprocess.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new test to verify that tox runs warning-free in a subprocess, which appears to be designed to reproduce issue #560 and is expected to fail initially.
- Adds
test_package_tests_toxfunction to verify tox environments run without warnings - Implements subprocess execution of tox with output capture for validation
- Includes assertion logic to check both test success and absence of warnings
Comment on lines
+178
to
+179
| return | ||
| output = tox_multienv_test_process.stdout.decode() |
There was a problem hiding this comment.
This assertion checks stdout for warnings, but many tools including tox typically output warnings to stderr. The warning check should examine stderr instead of stdout.
Suggested change
| return | |
| output = tox_multienv_test_process.stdout.decode() | |
| output = tox_multienv_test_process.stderr.decode() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduces #560. Should fail!